Review Request 125561: Align FindGettext with CMP002 policy

Hrvoje Senjan hrvoje.senjan at gmail.com
Sat Oct 10 00:42:49 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125561/
-----------------------------------------------------------

(Updated Oct. 10, 2015, 1:42 a.m.)


Review request for Build System, kdelibs, Localization and Translation (l10n), Albert Astals Cid, and Alexander Neundorf.


Changes
-------

Minimal surgery to FindGettext


Summary (updated)
-----------------

Align FindGettext with CMP002 policy


Repository: kdelibs


Description
-------

Otherwise some apps fail to build with kdelibs >= 4.14.11:
```
CMake Error at /usr/share/kde4/apps/cmake/modules/FindGettext.cmake:232 (ADD_CUSTOM_TARGET):
  add_custom_target cannot create target "pofiles" because another target
  with the same name already exists.  The existing target is a custom target
  created in source directory
  "/home/hrvoje/rpmbuild/BUILD/skanlite-1.1/po/be".  See documentation for
  policy CMP0002 for more details.
Call Stack (most recent call first):
  po/zh_CN/CMakeLists.txt:2 (GETTEXT_PROCESS_PO_FILES)
```


Diffs (updated)
-----

  cmake/modules/FindGettext.cmake 91e88f7 

Diff: https://git.reviewboard.kde.org/r/125561/diff/


Testing
-------

Skanlite now builds.


Thanks,

Hrvoje Senjan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20151009/f443a1e4/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem at kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem


More information about the kde-core-devel mailing list