Review Request 125560: Give unique names to the targets created by KDE4Macros.cmake

Luigi Toscano luigi.toscano at tiscali.it
Thu Oct 8 20:56:44 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125560/#review86521
-----------------------------------------------------------


This is the backport of the same fix applied long time ago to KDocTools, so generating longer, unique target names. The change is basically the same and it has been throughly tested. I would wait few days and if no one else object, I would give a ship it.

- Luigi Toscano


On Ott. 8, 2015, 7:38 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125560/
> -----------------------------------------------------------
> 
> (Updated Ott. 8, 2015, 7:38 p.m.)
> 
> 
> Review request for Build System, kdelibs and Luigi Toscano.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Backport of review 116650.
> Needed to fix build of some software after kdelibs' 4.14.11 cmake refactoring
> 
> 
> Diffs
> -----
> 
>   cmake/modules/KDE4Macros.cmake 8622959 
> 
> Diff: https://git.reviewboard.kde.org/r/125560/diff/
> 
> 
> Testing
> -------
> 
> k3b and skanlite tarballs now build.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20151008/484b2b91/attachment.htm>


More information about the kde-core-devel mailing list