Review Request 125476: Fix QUrl usage when calling QFileDialog::getExistingDirectory()

[Sergio Martins]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125476/
-----------------------------------------------------------

(Updated Oct. 2, 2015, 3:19 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdelibs and David Faure.


Changes
-------

Submitted with commit e46dc22d5fe84ed0a64e0712d8083756f99b3fa5 by Sergio Martins to branch master.


Repository: kio


Description
-------

- Passing openUrl.toString() is wrong, it should have been openUrl.path(), since the former has a scheme, and QFileDialog will call QUrl::fromLocalFile() on it.
- QFileDialog::getExistingDirectory() internally calls QFileDialog::getExistingDirectoryUrl() and converts the result to a local file string, which we then were re-converting to QUrl again, so instead just call getExistingDirectoryUrl() directly.


Diffs
-----

  src/widgets/kurlrequester.cpp 1b3bbdf 

Diff: https://git.reviewboard.kde.org/r/125476/diff/


Testing
-------


Thanks,

Sergio Martins

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20151002/39cd6805/attachment.htm>