Review Request 125476: Fix QUrl usage when calling QFileDialog::getExistingDirectory()
David Faure
faure at kde.org
Fri Oct 2 08:32:55 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125476/#review86216
-----------------------------------------------------------
Ship it!
Looks good, except for a bug in the commit log. You meant "should have been toLocalFile()" instead of "should have been path()" ;)
- David Faure
On Oct. 1, 2015, 8:58 p.m., Sergio Martins wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125476/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2015, 8:58 p.m.)
>
>
> Review request for kdelibs and David Faure.
>
>
> Repository: kio
>
>
> Description
> -------
>
> - Passing openUrl.toString() is wrong, it should have been openUrl.path(), since the former has a scheme, and QFileDialog will call QUrl::fromLocalFile() on it.
> - QFileDialog::getExistingDirectory() internally calls QFileDialog::getExistingDirectoryUrl() and converts the result to a local file string, which we then were re-converting to QUrl again, so instead just call getExistingDirectoryUrl() directly.
>
>
> Diffs
> -----
>
> src/widgets/kurlrequester.cpp 1b3bbdf
>
> Diff: https://git.reviewboard.kde.org/r/125476/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergio Martins
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20151002/ab6fa7ba/attachment.htm>
More information about the kde-core-devel
mailing list