Review Request 125476: Fix QUrl usage when calling QFileDialog::getExistingDirectory()

Sergio Martins smartins at
Thu Oct 1 21:58:22 BST 2015

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs and David Faure.

Repository: kio


- Passing openUrl.toString() is wrong, it should have been openUrl.path(), since the former has a scheme, and QFileDialog will call QUrl::fromLocalFile() on it.
- QFileDialog::getExistingDirectory() internally calls QFileDialog::getExistingDirectoryUrl() and converts the result to a local file string, which we then were re-converting to QUrl again, so instead just call getExistingDirectoryUrl() directly.


  src/widgets/kurlrequester.cpp 1b3bbdf 




Sergio Martins

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list