Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

Thomas L├╝bking thomas.luebking at gmail.com
Sun Nov 1 15:18:45 GMT 2015



> On Nov. 1, 2015, 2:18 nachm., Christoph Feck wrote:
> > kdeui/notifications/knotificationrestrictions.cpp, line 67
> > <https://git.reviewboard.kde.org/r/125910/diff/1/?file=414103#file414103line67>
> >
> >     I am not sure all compilers support initialization of (non-static) members inside the class declaration. I suggest to move it to the constructor.

c++03 - bad
c++11 - good

unless c++11 is required for the component (i don't really know about current kdelibs situation, but don't think so?), initializing a non-static member is invalid c++

=> You *have* to move it into the constructor

Also see http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2008/n2628.html

For anything that requires full (or this feature) c++11 support, the statement is fine.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125910/#review87800
-----------------------------------------------------------


On Nov. 1, 2015, 2:15 nachm., Johannes Stefan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125910/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2015, 2:15 nachm.)
> 
> 
> Review request for kdelibs and Martin Klapetek.
> 
> 
> Bugs: 334525
>     http://bugs.kde.org/show_bug.cgi?id=334525
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Setting default reason for going into fullscreen mode
> 
> 
> Diffs
> -----
> 
>   kdeui/notifications/knotificationrestrictions.cpp 818edea 
> 
> Diff: https://git.reviewboard.kde.org/r/125910/diff/
> 
> 
> Testing
> -------
> 
> Compiled an tested - DBus Log as expected:
> 
> ##### begin DBUS-log #####
> method call sender=:1.223 -> dest=org.freedesktop.ScreenSaver serial=56 path=/ScreenSaver; interface=org.freedesktop.ScreenSaver; member=Inhibit
>    string "Gwenview"
>    string "no_reason_specified"
> method call sender=:1.6 -> dest=:1.3 serial=588 path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; member=Inhibit
>    string "Gwenview"
>    uint32 0
>    string "no_reason_specified"
>    uint32 8
> signal sender=:1.3 -> dest=(null destination) serial=351 path=/org/gnome/SessionManager; interface=org.freedesktop.DBus.Properties; member=PropertiesChanged
>    string "org.gnome.SessionManager"
>    array [
>       dict entry(
>          string "InhibitedActions"
>          variant             uint32 8
>       )
>    ]
>    array [
>    ]
> signal sender=:1.3 -> dest=(null destination) serial=352 path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; member=InhibitorAdded
>    object path "/org/gnome/SessionManager/Inhibitor29"
> method return sender=:1.3 -> dest=:1.6 reply_serial=588
>    uint32 1169992534
> method call sender=:1.4 -> dest=:1.21 serial=56 path=/org/gnome/Mutter/IdleMonitor/Core; interface=org.gnome.Mutter.IdleMonitor; member=RemoveWatch
>    uint32 35
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=589 path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=AddMatch
>    string "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.223'"
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=590 path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=GetNameOwner
>    string ":1.223"
> method return sender=:1.6 -> dest=:1.223 reply_serial=56
>    uint32 1169992534
> method call sender=:1.6 -> dest=:1.21 serial=592 path=/org/gnome/Mutter/DisplayConfig; interface=org.freedesktop.DBus.Properties; member=Set
>    string "org.gnome.Mutter.DisplayConfig"
>    string "PowerSaveMode"
>    variant       int32 0
> method call sender=:1.21 -> dest=:1.3 serial=1073 path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; member=IsInhibited
>    uint32 16
> method call sender=:1.21 -> dest=org.freedesktop.DBus serial=1074 path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=RemoveMatch
>    string "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.4'"
> method return sender=:1.21 -> dest=:1.4 reply_serial=56
> method return sender=:1.3 -> dest=:1.21 reply_serial=1073
>    boolean false
> ##### end of DBUS-log #####
> 
> 
> Thanks,
> 
> Johannes Stefan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20151101/2ad75297/attachment.htm>


More information about the kde-core-devel mailing list