Review Request 123965: Encode KBookmark URL to fix compatibility with KDE4 applications

[Andrey Bondrov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123965/
-----------------------------------------------------------

Review request for Dolphin, kdelibs, David Faure, and Hrvoje Senjan.


Repository: kbookmarks


Description
-------

We need to encode KBookmark URL to fix compatibility with KDE4 applications.

For example, KDE4 stores "~/????????" ("Downloads" in Russian) as

bookmark href="file:///home/vuohi/%D0%97%D0%B0%D0%B3%D1%80%D1%83%D0%B7%D0%BA%D0%B8/"

while KF5 stores "~/????????" as

bookmark href="file:///home/vuohi/????????/"

When the bookmark is created with KF5, KDE4 applications cannot open it.


Diffs
-----

  src/kbookmark.cpp 98ddc99 

Diff: https://git.reviewboard.kde.org/r/123965/diff/


Testing
-------

Only quick testing is done. I deleted user-places.xbel, added bookmark with kwrite (KF5 version), checked if it's properly stored in new user-places.xbel and if Dolphin (KDE4 build) can open it from Places panel. Seems to work properly.


Thanks,

Andrey Bondrov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150531/11a4b263/attachment.htm>