Review Request 123881: Add KONSOLEPRIVATE_EXPORT to HistoryScroll since it's hasScroll method is needed.

Aleix Pol Gonzalez aleixpol at kde.org
Sun May 24 15:58:53 BST 2015



> On May 23, 2015, 2:23 a.m., Aleix Pol Gonzalez wrote:
> > Hm..
> > Builds here.
> > Also builds in build.kde.org... https://build.kde.org/job/konsole%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/2/
> > 
> > :/
> 
> Jeremy Whiting wrote:
>     I'm not sure why, but I did test a few times before making this change. Could it be because I'm building with gcc 5.1 again?

It could be, yes. Maybe we should also get CI with gcc 5... >.<


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123881/#review80746
-----------------------------------------------------------


On May 22, 2015, 9:49 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123881/
> -----------------------------------------------------------
> 
> (Updated May 22, 2015, 9:49 p.m.)
> 
> 
> Review request for KDE Base Apps and Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Without this HistoryTest fails to link here.
> 
> 
> Diffs
> -----
> 
>   src/History.h 6314ef993a329b3a7b52b5e43aeacafaf4d896de 
> 
> Diff: https://git.reviewboard.kde.org/r/123881/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150524/051c8583/attachment.htm>


More information about the kde-core-devel mailing list