Review Request 123806: [klipper] Ignore empty / blank entries

Patrick Eigensatz patrick.eigensatz at gmail.com
Mon May 18 23:07:31 BST 2015



> On Mai 18, 2015, 7:28 nachm., Patrick Eigensatz wrote:
> > klipper/historyitem.cpp, line 92
> > <https://git.reviewboard.kde.org/r/123806/diff/6/?file=370091#file370091line92>
> >
> >     Not sure if *text.isEmpty()* returns true if text=="\n\t \n"
> >     
> >     QT Documentation says: "Returns true if the string has no characters"
> >     
> >     I'm not sure if we could omit *.trimmed()*.
> 
> Thomas L├╝bking wrote:
>     > I'm not sure if we could omit .trimmed().
>     
>     No. isEmpty() only matches eg. "". Whether a character is printable is irrelevant - it's still a character.

Ok, so we keep it like this.


- Patrick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123806/#review80603
-----------------------------------------------------------


On Mai 18, 2015, 7:25 nachm., Patrick Eigensatz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123806/
> -----------------------------------------------------------
> 
> (Updated Mai 18, 2015, 7:25 nachm.)
> 
> 
> Review request for kde-workspace, KDE Usability and Patrick Eigensatz.
> 
> 
> Bugs: 159267 and 192922
>     https://bugs.kde.org/show_bug.cgi?id=159267
>     https://bugs.kde.org/show_bug.cgi?id=192922
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [PATCH] plasma-workspace: klipper: Fix #192922 Ignore blank entries
> 
> QString::isEmpty() is used to check if the string only consists of whitespace characters. If it does, the creation of the HistoryStringItem fails.
> 
> 
> Diffs
> -----
> 
>   klipper/generalconfig.ui f513e9c 
>   klipper/historyitem.cpp 36cbe61 
>   klipper/klipper.h 6952b11 
>   klipper/klipper.cpp 798b49f 
>   klipper/klipper.kcfg a03dd16 
> 
> Diff: https://git.reviewboard.kde.org/r/123806/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Patrick Eigensatz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150518/23add892/attachment.htm>


More information about the kde-core-devel mailing list