[KDE Usability] Review Request 123806: [klipper] Ignore empty / blank entries

Patrick Eigensatz patrick.eigensatz at gmail.com
Mon May 18 20:25:54 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123806/
-----------------------------------------------------------

(Updated Mai 18, 2015, 7:25 nachm.)


Review request for kde-workspace, KDE Usability and Patrick Eigensatz.


Changes
-------

Added option: "Allow whitespace entries" which is false by default.

I'm sorry as I still could not even compile this one :(


Bugs: 159267 and 192922
    https://bugs.kde.org/show_bug.cgi?id=159267
    https://bugs.kde.org/show_bug.cgi?id=192922


Repository: plasma-workspace


Description
-------

[PATCH] plasma-workspace: klipper: Fix #192922 Ignore blank entries

QString::isEmpty() is used to check if the string only consists of whitespace characters. If it does, the creation of the HistoryStringItem fails.


Diffs (updated)
-----

  klipper/generalconfig.ui f513e9c 
  klipper/historyitem.cpp 36cbe61 
  klipper/klipper.h 6952b11 
  klipper/klipper.cpp 798b49f 
  klipper/klipper.kcfg a03dd16 

Diff: https://git.reviewboard.kde.org/r/123806/diff/


Testing
-------


Thanks,

Patrick Eigensatz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150518/b06f9c5e/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-usability mailing list
kde-usability at kde.org
https://mail.kde.org/mailman/listinfo/kde-usability


More information about the kde-core-devel mailing list