[KDE Usability] Review Request 123806: [klipper] Ignore empty / blank entries

Thomas L├╝bking thomas.luebking at gmail.com
Sun May 17 11:28:56 BST 2015



> On Mai 16, 2015, 9:37 nachm., Patrick Eigensatz wrote:
> > klipper/historyitem.cpp, line 91
> > <https://git.reviewboard.kde.org/r/123806/diff/5/?file=369605#file369605line91>
> >
> >     I'm not sure if I can access "Klipper" from here. If I have a look at how this is done at other options then I see that they only use the *m_bSomeSetting* vars inside the klipper class itself.
> >     
> >     I need some help on how I should access the setting. (Pass it? Check it in the klipper class?)
> >     
> >     Thank you :)

ensure klippersettings.h is included (ie. add it, implicit inclusion is a timebomb) and use KlipperSettings::trimBlankEntries()

"Klipper" is a class and you cannot access a class this way.
If m_bTrimBlankEntries *was* (don't make it!) a static public member, you could access it via Klipper::m_bTrimBlankEntries (after including klipper.h here)

You're btw. expected to compile the changes.
Een reviews will easily oversee missing semicolons etc. - compilers do a far better job itr. ;-)


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123806/#review80490
-----------------------------------------------------------


On Mai 16, 2015, 9:31 nachm., Patrick Eigensatz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123806/
> -----------------------------------------------------------
> 
> (Updated Mai 16, 2015, 9:31 nachm.)
> 
> 
> Review request for kde-workspace, KDE Usability and Patrick Eigensatz.
> 
> 
> Bugs: 159267 and 192922
>     https://bugs.kde.org/show_bug.cgi?id=159267
>     https://bugs.kde.org/show_bug.cgi?id=192922
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [PATCH] plasma-workspace: klipper: Fix #192922 Ignore blank entries
> 
> QString::isEmpty() is used to check if the string only consists of whitespace characters. If it does, the creation of the HistoryStringItem fails.
> 
> 
> Diffs
> -----
> 
>   klipper/generalconfig.ui f513e9c 
>   klipper/historyitem.cpp 36cbe61 
>   klipper/klipper.h 6952b11 
>   klipper/klipper.cpp 798b49f 
>   klipper/klipper.kcfg a03dd16 
> 
> Diff: https://git.reviewboard.kde.org/r/123806/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Patrick Eigensatz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150517/0e1eb2b5/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-usability mailing list
kde-usability at kde.org
https://mail.kde.org/mailman/listinfo/kde-usability


More information about the kde-core-devel mailing list