Review Request 123806: [klipper] Ignore empty / blank entries

[Christoph Feck]

> On May 16, 2015, 4:37 p.m., Christoph Feck wrote:
> > klipper/klipper.kcfg, line 32
> > <https://git.reviewboard.kde.org/r/123806/diff/3/?file=369517#file369517line32>
> >
> >     It would be immensely useful, if Klipper also showed leading/trailing whitespace, i.e. for items that aren't completely whitespace.
> >     
> >     Firefox loves to add leading whitespace when copying double-clicked text, but Klipper does not show this in the menu.

See bug 159267.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123806/#review80466
-----------------------------------------------------------


On May 16, 2015, 12:40 p.m., Patrick Eigensatz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123806/
> -----------------------------------------------------------
> 
> (Updated May 16, 2015, 12:40 p.m.)
> 
> 
> Review request for kde-workspace, KDE Usability and Patrick Eigensatz.
> 
> 
> Bugs: 192922
>     https://bugs.kde.org/show_bug.cgi?id=192922
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [PATCH] plasma-workspace: klipper: Fix #192922 Ignore blank entries
> 
> QString::isEmpty() is used to check if the string only consists of whitespace characters. If it does, the creation of the HistoryStringItem fails.
> 
> 
> Diffs
> -----
> 
>   klipper/configdialog.cpp 2fe8206 
>   klipper/generalconfig.ui f513e9c 
>   klipper/historyitem.cpp 36cbe61 
>   klipper/klipper.h 6952b11 
>   klipper/klipper.cpp 798b49f 
>   klipper/klipper.kcfg a03dd16 
> 
> Diff: https://git.reviewboard.kde.org/r/123806/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Patrick Eigensatz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150516/c5dbc2c8/attachment.htm>