Review Request 123806: [klipper] Ignore empty / blank entries

[Patrick Eigensatz]

> On Mai 15, 2015, 7:31 nachm., Martin Gräßlin wrote:
> > thanks for rebasing!
> > 
> > I just had a look at the bug report and have to agree with comment #1: I do from time to time copy on purpose whitespaces (yes I'm weird). I also tend to copy newlines and I do want to have them in the history. If I understand your commit description correctly this "feature" would break.
> > 
> > Given that I think we need more input on whether we want to break that feature or whether we want to create a config option for it.

Hi Martin!

Yes, this "feature" would break. However, if you copy more than one whitespace sequence you won't be able to identify them in the klipper menu.
But your concerns are right. I could try to implement an option for this, although I've never done this before and I would surely need some assistance...


- Patrick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123806/#review80423
-----------------------------------------------------------


On Mai 15, 2015, 6:50 nachm., Patrick Eigensatz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123806/
> -----------------------------------------------------------
> 
> (Updated Mai 15, 2015, 6:50 nachm.)
> 
> 
> Review request for kde-workspace and Patrick Eigensatz.
> 
> 
> Bugs: 192922
>     https://bugs.kde.org/show_bug.cgi?id=192922
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [PATCH] plasma-workspace: klipper: Fix #192922 Ignore blank entries
> 
> QString::isEmpty() is used to check if the string only consists of whitespace characters. If it does, the creation of the HistoryStringItem fails.
> 
> 
> Diffs
> -----
> 
>   klipper/historyitem.cpp 36cbe61 
> 
> Diff: https://git.reviewboard.kde.org/r/123806/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Patrick Eigensatz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150515/c9d897b6/attachment.htm>