Review Request 123797: [PATCH] klipper: Ignore blank entries

[Patrick Eigensatz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123797/
-----------------------------------------------------------

(Updated Mai 15, 2015, 6:05 nachm.)


Review request for kde-workspace and Patrick Eigensatz.


Changes
-------

Uploaded the patchfile containing 2 commits:
1. Fix the issue
2. Code Cleanup


Bugs: 192922
    http://bugs.kde.org/show_bug.cgi?id=192922


Repository: kde-workspace


Description
-------

[PATCH] kde-workspace: klipper: Fix #192922 Ignore blank entries


QString::trimmed() is used to check if the string only consists of whitespace characters. If it does, the creation of the HistoryStringItem fails.


Diffs
-----

  plasma-workspace/klipper/history.cpp 486e8f7 
  plasma-workspace/klipper/historyitem.cpp e9bdec7 
  plasma-workspace/klipper/klipper.cpp cde65f5 

Diff: https://git.reviewboard.kde.org/r/123797/diff/


Testing
-------


File Attachments (updated)
----------------

The patchfile containing both commits
  https://git.reviewboard.kde.org/media/uploaded/files/2015/05/15/c938fefd-9fe6-41bf-860a-e161920669a6__patchfile.patch


Thanks,

Patrick Eigensatz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150515/5236a073/attachment.htm>