Review Request 123186: Add autohint checkbox to KCM fonts

[Thomas Lübking]

> On März 30, 2015, 5:01 nachm., Thomas Lübking wrote:
> > From my own experience, autohinting is no "yes or no" question.
> > => Should downstream not rather provide global fontconfig snippets that enable autohinting for fonts with (known) crap BC hinting?
> 
> Andrey Bondrov wrote:
>     Sometimes it's still "yes or no". For example, I prefer to turn subpixel rendering and BC off for Liberation Sans (just because I don't want my fonts to be RGB-colored). But I guess most people prefer subpixel rendering and BC for Liberation Sans fonts. BC for LS fonts is a matter of taste.

I think this is a misunderstanding:
I did not mean "it's not a matter of choice" but rather "it *is* a matter of choice *per font*"

Ie. some fonts have great BC hinting and some (ok: many fun-fonts found on dafont ;-) have crap hints. For them the autohinter would produce better results, by the cost of damaging the usefully hinted ones.

I'm not familiar w/ the code, but it looks like it applies a global match, ie. _all_ fonts will be autohinted, not the one(s) set in that kcm?


Subpixel rendering otoh is (to me) rather a matter of personal global taste, maybe combined w/ the display (resolution)


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123186/#review78234
-----------------------------------------------------------


On März 30, 2015, 3:42 nachm., Andrey Bondrov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123186/
> -----------------------------------------------------------
> 
> (Updated März 30, 2015, 3:42 nachm.)
> 
> 
> Review request for kde-workspace, Martin Gräßlin and Eike Hein.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> We need to add autohint checkbox to KCM fonts, this feature is requested by various users downstream (for example, see https://bugs.mageia.org/show_bug.cgi?id=1240 ).
> 
> I patched kde-workspace 4.9 in 2012, now I'd like to submit my patch upstream to have this feature in Plasma 5 for every distribution.
> 
> BTW, LXQt already added autohint option to font settings several monthes ago: https://github.com/lxde/lxqt-config/pull/13#event-187605798
> 
> 
> Diffs
> -----
> 
>   kcms/fonts/fonts.h d98bbe2 
>   kcms/fonts/fonts.cpp 9b065e6 
>   kcms/fonts/kxftconfig.h 8e79595 
>   kcms/fonts/kxftconfig.cpp 2cc3a1b 
> 
> Diff: https://git.reviewboard.kde.org/r/123186/diff/
> 
> 
> Testing
> -------
> 
> Old KDE 4 patch was used by ROSA and OpenMandriva since 2012, no issues with it. I had to adjust it a bit to follow Plasma 5 changes but in general it's old well-tested patch. Seems to work fine for me.
> 
> 
> Thanks,
> 
> Andrey Bondrov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150331/abac88b8/attachment.htm>