Review Request 123169: Show percentage value beside brightness level slider

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123169/#review78180
-----------------------------------------------------------


Thank you for this patch!

However, we chose to remove the percentage from the brightness sliders in the battery monitor since you basically change the brightness to your liking and not to some odd percentage, so adding them back in the PowerDevil settings doesn't make sense.

- Kai Uwe Broulik


On März 29, 2015, 9:42 vorm., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123169/
> -----------------------------------------------------------
> 
> (Updated März 29, 2015, 9:42 vorm.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> I prefer to keep the same brightness level for all profiles. But its a bit difficult to set the same value in all tabs using just the slider. This patch adds a percentage value next to the slider. Screenshot included.
> 
> 
> Diffs
> -----
> 
>   daemon/actions/bundled/brightnesscontrolconfig.h 7ba29a7 
>   daemon/actions/bundled/brightnesscontrolconfig.cpp 3b5aaad 
> 
> Diff: https://git.reviewboard.kde.org/r/123169/diff/
> 
> 
> Testing
> -------
> 
> Compiles. KCM displays the percentage corresponding to slider value in all tabs.
> 
> 
> File Attachments
> ----------------
> 
> Slider with percentage
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/03/29/359f2e65-c52c-4e4e-9c8a-c75c3a9a8576__kcm.png
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150329/ca49f734/attachment.htm>