Review Request 122987: Allow user to specify path to myspell dictionary files

Rolf Eike Beer kde at opensource.sf-tec.de
Tue Mar 17 21:13:32 GMT 2015



> On März 17, 2015, 1:07 nachm., Laurent Montel wrote:
> > src/plugins/hunspell/hunspellclient.cpp, line 27
> > <https://git.reviewboard.kde.org/r/122987/diff/3/?file=355372#file355372line27>
> >
> >     #include "..."
> >     we use local file.

No, the file is in an include path, not in the same directory as the source file (binary vs. source dir).


- Rolf Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77630
-----------------------------------------------------------


On März 17, 2015, 1:09 nachm., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122987/
> -----------------------------------------------------------
> 
> (Updated März 17, 2015, 1:09 nachm.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Repository: sonnet
> 
> 
> Description
> -------
> 
> Not on all systems myspell dictionaries are located in /usr/share/myspell/dicts/,  which is hardcoded in the hunspell plugin sources. For instance, on Gentoo it is /usr/share/myspell/. So let the user define this path.
> 
> 
> Diffs
> -----
> 
>   src/plugins/hunspell/CMakeLists.txt 098fb49 
>   src/plugins/hunspell/config-hunspellplugin.h.cmake PRE-CREATION 
>   src/plugins/hunspell/hunspellclient.cpp 9e3aa67 
>   src/plugins/hunspell/hunspelldict.cpp 621113d 
> 
> Diff: https://git.reviewboard.kde.org/r/122987/diff/
> 
> 
> Testing
> -------
> 
> hunspell plugin began to work on Gentoo
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150317/528e8a1d/attachment.htm>


More information about the kde-core-devel mailing list