Review Request 122652: Use correct default value when UDS_ACCESS/UDS_FILE_TYPE is not set

[David Faure]

> On March 17, 2015, 4:38 p.m., David Faure wrote:
> > Ship It!

Yes, both in kdelibs 4 and in the kio framework.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122652/#review77642
-----------------------------------------------------------


On March 17, 2015, 4:17 p.m., Stefan Brüns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122652/
> -----------------------------------------------------------
> 
> (Updated March 17, 2015, 4:17 p.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs and David Faure.
> 
> 
> Bugs: 339193
>     http://bugs.kde.org/show_bug.cgi?id=339193
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> The default value for UDSEntry::numberValue(...) is 0, whereas KFileItem
> uses the special value KFileItem::Unknown == (mode_t) -1.
> 
> CCBUG: 339193
> 
> 
> Diffs
> -----
> 
>   kio/kio/kfileitem.cpp f431d3608cfe646fb882365921e694af8ff8838f 
> 
> Diff: https://git.reviewboard.kde.org/r/122652/diff/
> 
> 
> Testing
> -------
> 
> dolphin remote:
> -> no lock icon on smb:, mtp:, ... links
> 
> 
> Thanks,
> 
> Stefan Brüns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150317/66de4792/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel