Review Request 122987: Allow user to specify path to myspell dictionary files

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77619
-----------------------------------------------------------



src/plugins/hunspell/hunspellclient.cpp
<https://git.reviewboard.kde.org/r/122987/#comment53306>

    #include "hunspell-plugin-conf.h"
    
    and in all module we use config-*.h.cmake
    
    => better to rename it config-hunspellplugin.h.cmake



src/plugins/hunspell/hunspelldict.cpp
<https://git.reviewboard.kde.org/r/122987/#comment53307>

    you can change this qDebug too :)
    qDebug()<<" m_speller : "<<m_speller;
    
    Ok it's not your fault but it will good to fix it :)


- Laurent Montel


On mars 17, 2015, 12:22 après-midi, Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122987/
> -----------------------------------------------------------
> 
> (Updated mars 17, 2015, 12:22 après-midi)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: sonnet
> 
> 
> Description
> -------
> 
> Not on all systems myspell dictionaries are located in /usr/share/myspell/dicts/,  which is hardcoded in the hunspell plugin sources. For instance, on Gentoo it is /usr/share/myspell/. So let the user define this path.
> 
> 
> Diffs
> -----
> 
>   src/plugins/hunspell/CMakeLists.txt 098fb49 
>   src/plugins/hunspell/hunspell-plugin-conf.h.cmake PRE-CREATION 
>   src/plugins/hunspell/hunspellclient.cpp 9e3aa67 
>   src/plugins/hunspell/hunspelldict.cpp 621113d 
> 
> Diff: https://git.reviewboard.kde.org/r/122987/diff/
> 
> 
> Testing
> -------
> 
> hunspell plugin began to work on Gentoo
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150317/73724ab7/attachment.htm>