Review Request 122652: Use correct default value when UDS_ACCESS/UDS_FILE_TYPE is not set

[Luigi Toscano]

> On Feb. 25, 2015, 6:57 p.m., Mark Gaiser wrote:
> > I "think" this is OK, but just don't know.
> > 
> > Anyway, your diff is for kdelibs (KDE SC 4.xx). I don't know if that gets another release. Either way, KIO frameworks [1] is where this should be applied to when you get a ship it.
> > [1] http://quickgit.kde.org/?p=kio.git
> 
> Luigi Toscano wrote:
>     kdelibs 4.14 still receives fixes and it's released with KDE Applications (at least as long as we have kdelibs4-based applications). So, if it fixes a bug, it can go in.
>     Of course it should be forward-ported to KIO Framework if it is still relevant there.
> 
> Stefan Brüns wrote:
>     So shall I commit this (and https://git.reviewboard.kde.org/r/122653/ as well)?
>     
>     AFAIK next Applications release is due in short time.
>     
>     Will of course forward port to KF5
> 
> Stefan Brüns wrote:
>     I am still waiting for a ship it. Patch applies cleanly to KF5 kio ...

Sorry, but I'm not the one who can give a "Ship it" on this. As this is also a bug fix for the kio framework, I would add the kdeframeworks group and the kio maintainer (dfaure) to the review.


- Luigi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122652/#review76626
-----------------------------------------------------------


On Feb. 20, 2015, 10:28 p.m., Stefan Brüns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122652/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2015, 10:28 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Bugs: 339193
>     http://bugs.kde.org/show_bug.cgi?id=339193
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> The default value for UDSEntry::numberValue(...) is 0, whereas KFileItem
> uses the special value KFileItem::Unknown == (mode_t) -1.
> 
> CCBUG: 339193
> 
> 
> Diffs
> -----
> 
>   kio/kio/kfileitem.cpp f431d3608cfe646fb882365921e694af8ff8838f 
> 
> Diff: https://git.reviewboard.kde.org/r/122652/diff/
> 
> 
> Testing
> -------
> 
> dolphin remote:
> -> no lock icon on smb:, mtp:, ... links
> 
> 
> Thanks,
> 
> Stefan Brüns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150317/d2e0050e/attachment.htm>