Review Request 122922: Remove two asserts from kzip.cpp

Boudewijn Rempt boud at valdyas.org
Fri Mar 13 08:34:45 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122922/
-----------------------------------------------------------

(Updated March 13, 2015, 8:34 a.m.)


Status
------

This change has been marked as submitted.


Review request for kdelibs.


Bugs: 343214
    http://bugs.kde.org/show_bug.cgi?id=343214


Repository: kdelibs


Description
-------

These asserts should never hit, return false is much safer. I'll submit the same patch for karchive.


Diffs
-----

  kdecore/io/kzip.cpp 26ee9a7 

Diff: https://git.reviewboard.kde.org/r/122922/diff/


Testing
-------

Tested with Krita in circumstances descibed in the bug.


Thanks,

Boudewijn Rempt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150313/8a68f573/attachment.htm>


More information about the kde-core-devel mailing list