Review Request 122826: Bug 339392 - krdc main window columns are not resizable

[Luca]

Hi Urs

That line is the problem. Reading at the doc about
QHeaderView::ResizeToContents
...
The size cannot be changed by the user or programmatically.

is enought resize the column manually after the model is populated and the
sort indicator is setted up.

Ps. I canno't commit into master

bye


On 6 March 2015 at 19:00, Urs Wolfer <uwolfer at kde.org> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122826/
>
> Will you commit this change into master?
>
>
>    mainwindow.cpp
> <https://git.reviewboard.kde.org/r/122826/diff/1/?file=353016#file353016line1129> (Diff
> revision 1)
>
> QWidget* MainWindow::newConnectionWidget()
>
>   1129
>
>         m_newConnectionTableView->horizontalHeader()->setResizeMode(QHeaderView::ResizeToContents);
>
>    Are you sure this line isn't needed anymore?
>
>
> - Urs Wolfer
>
> On March 5th, 2015, 4:57 p.m. UTC, Luca Sartorelli wrote:
>   Review request for KDE Base Apps, KDE Utils, Network Management, and
> Urs Wolfer.
> By Luca Sartorelli.
>
> *Updated March 5, 2015, 4:57 p.m.*
>  *Bugs: * 339392 <http://bugs.kde.org/show_bug.cgi?id=339392>
>  *Repository: * krdc
> Description
>
> Bug 339392 - krdc main window columns are not resizable
>
>   Testing
>
> The columns of the main grid in the main windows are resizable, and when the application starts, are sized nicely as without the patch.
> On a new connect window, the column are not resize (same as before), but this time is possible to resize them, by the mouse
>
>   Diffs
>
>    - mainwindow.cpp (acc89ae)
>
> View Diff <https://git.reviewboard.kde.org/r/122826/diff/>
>



-- 
P Please consider the environment before printing this e-mail
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150309/3bb0f4c4/attachment.htm>