Please help me get my pending review count down

[Milian Wolff]

On Wednesday, July 29, 2015 11:03:15 AM Martin Klapetek wrote:
> On Wed, Jul 29, 2015 at 11:47 AM, Marc Mutz <marc.mutz at kdab.com> wrote:
> > On Wednesday 29 July 2015 09:04:42 Martin Klapetek wrote:
> > > Can you perhaps create a single diff against 5.5/dev/master
> > > which could be easily applied? That should make things
> > > much easier to help :)
> > 
> > Assuming you're talking about the dbus changes, wouldn't you actually want
> > to
> > cherry-pick them one by one and see which one breaks?
> 
> Perhaps that should be done as well, yes, although Thiago requested the
> /whole set of changes/ to be tested:
> 
> I need someone to take the whole set of changes, apply to their Qt 5.5 build
> > and test KF5-powered applications to see what gets broken and why. Please
> > provide patches to either QtDBus, KF5 or the applications.
> 
> Which would be much simpler with a single diff.

Gerrit gives you a git command to copy'n'paste and you can pull the changeset 
and test it. That's much better than manually applying some plaintext diff.

Bye
-- 
Milian Wolff | milian.wolff at kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5903 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150729/8df319b0/attachment.bin>
-------------- next part --------------
_______________________________________________
Development mailing list
Development at qt-project.org
http://lists.qt-project.org/mailman/listinfo/development