Please help me get my pending review count down

[Thiago Macieira]

[cross-posting to k-c-d to get KDE dev attention]

On Tuesday 28 July 2015 14:51:49 Thiago Macieira wrote:
> - QtDBus changes:
> https://codereview.qt-project.org/101967
> https://codereview.qt-project.org/102762
> https://codereview.qt-project.org/103731
> https://codereview.qt-project.org/103732
> https://codereview.qt-project.org/103733
> https://codereview.qt-project.org/103734
> https://codereview.qt-project.org/103735
> https://codereview.qt-project.org/103736
> https://codereview.qt-project.org/103737
> https://codereview.qt-project.org/103738
> https://codereview.qt-project.org/103739
> https://codereview.qt-project.org/103740
> https://codereview.qt-project.org/109632
> https://codereview.qt-project.org/109633
> https://codereview.qt-project.org/109634
> https://codereview.qt-project.org/109635
> https://codereview.qt-project.org/109636
> https://codereview.qt-project.org/109859
> https://codereview.qt-project.org/109860
> https://codereview.qt-project.org/110204
> https://codereview.qt-project.org/110446
> https://codereview.qt-project.org/110447
> 
> On the QtDBus changes: most are already reviewed and approved (thanks
> Alex!),  but I need someone to investigate why KUniqueApplication is broken
> in konsole. There will be no new bugfixes or features to QtDBus until the
> set of changes above integrates because everything I develop (as can be
> seen from the change numbers) comes on top of the existing changes that
> haven't integrated.

The changes listed above have been pending for months, especially because they 
seem to break konsole. As I don't have a debug build of a KF5-powered Konsole 
(or a release one, for that matter), I cannot debug this issue. I need help.

I need someone to take the whole set of changes, apply to their Qt 5.5 build 
and test KF5-powered applications to see what gets broken and why. Please 
provide patches to either QtDBus, KF5 or the applications.

If you can't provide patches, information will be welcome so others may 
produce patches. I may try to fix the issue myself, but it's not easy to do 
blind fixes for issues you can't reproduce.

Deadline: 6 weeks before Qt 5.7 feature freeze.

If we reach that date and the patches are still not integrated, I will have to 
make a decision as Maintainer as to the future of them. It will be to either 
apply them despite any breakages caused in KDE applications or to drop them 
altogether, including all the fixes for race conditions and deadlocks. I will 
probably err on the side of caution, though.

We don't want either to occur.

Can anyone help?

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358