Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122341/#review75101
-----------------------------------------------------------



thumbnail/thumbnail.cpp
<https://git.reviewboard.kde.org/r/122341/#comment51969>

    Please do not use "//" on every line to disable a section of code. It touches every line in the git change log. Better use "#if" on a separate line.


- Christoph Feck


On Jan. 31, 2015, 6:24 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122341/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2015, 6:24 p.m.)
> 
> 
> Review request for kde-workspace, Bhushan Shah and David Faure.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> Only major difference would be the lack of fallback to KFMI. Maybe we could implement thumbnail features in KFileMetadata?
> 
> 
> Diffs
> -----
> 
>   thumbnail/thumbnail.cpp 39e8de5 
> 
> Diff: https://git.reviewboard.kde.org/r/122341/diff/
> 
> 
> Testing
> -------
> 
> Only tested compilation.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150131/2a408ac6/attachment.htm>