Review Request 122270: port kcminit away from kdelibs4support

[Nick Shaforostoff]

> On Січ. 29, 2015, 2:36 після полудня, Martin Gräßlin wrote:
> > I'm surprised that you pushed the change although the review was not finished and you hadn't a shipit on any of the versions.
> 
> Thomas Lübking wrote:
>     Nick, though it does not seem as if you had introduced it, the "QGuiApplication::screens().count() > 1" check is, as has been pointed out in this review several times, still wrong for sure.
>     Do you intend to keep working on this code? (to get rid of QGuiApplication and perhaps the ini read)

sorry, should i revert the commit?

yes, i intend to create a new review request with 'QGuiApplication::screens().count() > 1' replacement using xcb routines.


- Nick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122270/#review74982
-----------------------------------------------------------


On Січ. 29, 2015, 11:58 до полудня, Nick Shaforostoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122270/
> -----------------------------------------------------------
> 
> (Updated Січ. 29, 2015, 11:58 до полудня)
> 
> 
> Review request for kde-workspace, Aleix Pol Gonzalez, Martin Gräßlin, and Lukáš Tinkl.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Now kcminit is linked with less libraries -> startup time improved
> 
> I also suggest always setting KDE_MULTIHEAD=true to eliminate ini file access during startup and to be able to stop linking against QtGui
> 
> 
> Diffs
> -----
> 
>   startkde/kcminit/CMakeLists.txt ffae38c 
>   startkde/kcminit/main.h 1140b77 
>   startkde/kcminit/main.cpp 4724323 
> 
> Diff: https://git.reviewboard.kde.org/r/122270/diff/
> 
> 
> Testing
> -------
> 
> compiled, ran 'kcminit --list' and kcminit AAA
> 
> 
> Thanks,
> 
> Nick Shaforostoff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150129/acc42939/attachment.htm>