Review Request 122267: ki18n: Make it build with msvc compilers again

Cristian Oneț onet.cristian at gmail.com
Tue Jan 27 07:30:30 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122267/#review74809
-----------------------------------------------------------

Ship it!


Ship It!

- Cristian Oneț


On Jan. 27, 2015, 12:55 a.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122267/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2015, 12:55 a.m.)
> 
> 
> Review request for kdelibs, kdewin and Nicolás Alvarez.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> QStringLiteral documentation says: 
> 
> Concatenated string literals cannot be used with QStringLiteral.
> QString s = QStringLiteral("a" "b");
> 
> which causes ki18n to not build on msvc 2013 here. This patch makes it build again.
> 
> 
> Diffs
> -----
> 
>   src/kuitmarkup.cpp e2dda98 
> 
> Diff: https://git.reviewboard.kde.org/r/122267/diff/
> 
> 
> Testing
> -------
> 
> Now ki18n builds with msvc2013
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150127/fc48aa3b/attachment.htm>


More information about the kde-core-devel mailing list