Review Request 121831: libksysguard: process.h: encapsulate private fields

Gregor Mi codestruct at
Sun Jan 18 23:03:46 GMT 2015

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 18, 2015, 11:03 p.m.)

Review request for KDE Base Apps, Eike Hein and John Tapsell.


Updated to use d-ptr as suggested. I added you to this RR, Eike. Maybe you can take a look if the way I started to use the d-ptr is the correct one.

Repository: libksysguard


In process.h there are several public fields. I propose to encapsulate the private fields with getter methods. I implemented it exemplary for the fields 'login', 'uid' and 'euid'.

(In a separate commit I would add the .reviewboardrc file)

What is the current policy on using small C++ macros as done in this RR? Use it (code is more compact and readable) or don't use it (better for debugging)?

Diffs (updated)

  .reviewboardrc PRE-CREATION 
  CMakeLists.txt cefc86f12be684e195bd148641483e9e1734e636 
  processcore/process.h b6695c0ed301dc5f0fad8ba847da811f19ebfd9a 
  processcore/process.cpp a38b8be71da1a51cb87f636664ebac817b1d20ab 
  processcore/processes_linux_p.cpp 898d4fa491873fe95a8b32a5c1b85642b2e46ad5 
  processui/ProcessFilter.cpp ec520593fb67c777d56817f2493d40dc5ade0347 
  processui/ProcessModel.cpp 53bc041110c9cdb686fef783895104969b661889 
  processui/scripting.h 2445c0ab0d81af3283c0f6e9c5f349a3d70b0de9 



Compiles and runs. Data is still shown. No error.


Gregor Mi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list