Review Request 121879: Improve KCoreConfigSkeleton tests

Matthew Dawson matthew at mjdsystems.ca
Tue Jan 6 19:18:32 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121879/#review73296
-----------------------------------------------------------


+1 from me.

- Matthew Dawson


On Jan. 6, 2015, 6:51 a.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121879/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2015, 6:51 a.m.)
> 
> 
> Review request for kdelibs, David Faure and Matthew Dawson.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Backport from tests from https://git.reviewboard.kde.org/r/121838/
> 
> We have not decided how to fix yet in KConfig but i think adding the test to kdelibs makes sense to make sure we don't regress by mistake in a future LTS release of kdelibs.
> 
> 
> Diffs
> -----
> 
>   kdeui/tests/kconfigskeletontest.h 8167c62 
>   kdeui/tests/kconfigskeletontest.cpp 2bac0e1 
> 
> Diff: https://git.reviewboard.kde.org/r/121879/diff/
> 
> 
> Testing
> -------
> 
> Tests pass
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150106/1201243f/attachment.htm>


More information about the kde-core-devel mailing list