Review Request 119363: Port kde-baseapps to use docbook 4.5

[Luigi Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119363/#review76786
-----------------------------------------------------------


The changes described in this review have been applied long time. The encoding issue has been addressed in the following two reviews:
 * kdoctools: https://git.reviewboard.kde.org/r/120648/
 * kdelibs4support: https://git.reviewboard.kde.org/r/120649/

which are now pushed and closed. So this review can be closed.

- Luigi Toscano


On Aug. 24, 2014, 6:33 p.m., Marko Käning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119363/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2014, 6:33 p.m.)
> 
> 
> Review request for KDE Base Apps, Luigi Toscano and Nicolás Alvarez.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> This suggests to upgrade the docbook DTD from 4.2 to 4.5.
> 
> ---
> 
> There is still an open issue here:
> 
>  Spaces in DATA_INSTALL_DIR need to be handled properly, so that the path in the DTD file
> 
>     /Library/Application\ Support/kf5/kdoctools/customization/dtd/kdex.dtd
> 
>  is correctly set, i.e. using "%20" instead of a space.
> 
> 
> Diffs
> -----
> 
>   doc/konqueror/index.docbook a1f8565404be0289b51af37df1687e0911a01fe5 
>   dolphin/docs/index.docbook 5fe85f5d130e3723af556fb02b53970206d1c765 
>   kdepasswd/docs/index.docbook 2ecef470ac8a9384b7aeb16f123f834d040ee375 
>   kfind/docs/index.docbook d46dfa4138991a356eec32a7043a883150eb81c2 
>   kfind/docs/man-kfind.1.docbook ef2eb3b9fb1ed1a84ae33fa631b0295a029444e0 
> 
> Diff: https://git.reviewboard.kde.org/r/119363/diff/
> 
> 
> Testing
> -------
> 
> Builds/installs fine (if one doesn't use any white-space in DATA_INSTALL_DIR path) 
> 
> 
> Thanks,
> 
> Marko Käning
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150228/00fb8781/attachment.htm>