Review Request 121831: libksysguard: process.h: encapsulate private fields

[Hrvoje Senjan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121831/#review76358
-----------------------------------------------------------


can you check what needs to be adjusted in plasma-workspace? it fails to build with your change:



[  451s] /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp:471:43: error: 'proc->KSysGuard::Process::command' does not have class type
[  451s]      QString cmdline = proc ? proc->command.simplified() : QString(); // proc->command has a trailing space???
[  451s]                                            ^
[  451s] /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp:501:103: error: no matching function for call to 'KService::KService(<unresolved overloaded function type>, QString&, QString)'
[  451s]          services << QExplicitlySharedDataPointer<KService>(new KService(proc->name, cmdline, QString()));
[  451s]                                                                                                        ^
[  451s] /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp:501:103: note: candidates are:
[  451s] In file included from /usr/include/KF5/KService/KService:1:0,
[  451s]                  from /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp:32:
[  451s] /usr/include/KF5/KService/kservice.h:580:5: note: KService::KService(QDataStream&, int)
[  451s]      KService(QDataStream &str, int offset);
[  451s]      ^
[  451s] /usr/include/KF5/KService/kservice.h:580:5: note:   candidate expects 2 arguments, 3 provided
[  451s] In file included from /usr/include/KF5/KService/KService:1:0,
[  451s]                  from /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp:32:
[  451s] /usr/include/KF5/KService/kservice.h:82:14: note: KService::KService(const KDesktopFile*, const QString&)
[  451s]      explicit KService(const KDesktopFile *config, const QString &entryPath = QString());
[  451s]               ^
[  451s] /usr/include/KF5/KService/kservice.h:82:14: note:   candidate expects 2 arguments, 3 provided
[  451s] /usr/include/KF5/KService/kservice.h:75:14: note: KService::KService(const QString&)
[  451s]      explicit KService(const QString &fullpath);
[  451s]               ^
[  451s] /usr/include/KF5/KService/kservice.h:75:14: note:   candidate expects 1 argument, 3 provided
[  451s] /usr/include/KF5/KService/kservice.h:68:5: note: KService::KService(const QString&, const QString&, const QString&)
[  451s]      KService(const QString &name, const QString &exec, const QString &icon);
[  451s]      ^
[  451s] /usr/include/KF5/KService/kservice.h:68:5: note:   no known conversion for argument 1 from '<unresolved overloaded function type>' to 'const QString&'
[  451s] /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp: In function 'QUrl TaskManager::getServiceLauncherUrl(int, const QString&, const QStringList&)':
[  451s] /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp:516:43: error: 'proc->KSysGuard::Process::command' does not have class type
[  451s]      QString cmdline = proc ? proc->command.simplified() : QString(); // proc->command has a trailing space???
[  451s]                                            ^

- Hrvoje Senjan


On Feb. 20, 2015, 10:46 p.m., Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121831/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2015, 10:46 p.m.)
> 
> 
> Review request for KDE Base Apps, Dominik Haumann, Eike Hein, and John Tapsell.
> 
> 
> Repository: libksysguard
> 
> 
> Description
> -------
> 
> This is a follow-up to https://git.reviewboard.kde.org/r/121717/:
> 
> In process.h there are several public fields which easily trigger BIC changes. This RR introduces a d-ptr.
> 
> (In a separate commit I would add the .reviewboardrc file)
> 
> 
> Diffs
> -----
> 
>   processui/scripting.h 2445c0ab0d81af3283c0f6e9c5f349a3d70b0de9 
>   processui/scripting.cpp 76291b0ae0a26e486aa81a4ca3976ff4a47cb3c0 
>   processcore/processes_solaris_p.cpp f054df4b1e762e9cbec1ff8dea78f467b878bee0 
>   processui/ProcessFilter.cpp ec520593fb67c777d56817f2493d40dc5ade0347 
>   processui/ProcessModel.cpp 53bc041110c9cdb686fef783895104969b661889 
>   processui/ksysguardprocesslist.cpp 4dc142e864d8353ceafc3a6735ffa81e48291420 
>   processcore/processes.cpp 580df8db152040f1ad075430fdce08fe7ad4ae2d 
>   processcore/processes_atop_p.cpp 24c76e3e35f62bd8e9e705ad32cc11cbd3662601 
>   processcore/processes_base_p.h 71b8a9cc6ee14bf7934a0a9d3199b257b5ce1be7 
>   processcore/processes_linux_p.cpp 898d4fa491873fe95a8b32a5c1b85642b2e46ad5 
>   processcore/processes.h d09c3265333fe7e2702deaa910c5fbe4bc3ac9e6 
>   tests/processtest.cpp f9b36e9a3a3c2048b51f1d935f8c40de2ad8a9b8 
>   .reviewboardrc PRE-CREATION 
>   CMakeLists.txt cefc86f12be684e195bd148641483e9e1734e636 
>   processcore/process.h b6695c0ed301dc5f0fad8ba847da811f19ebfd9a 
>   processcore/process.cpp a38b8be71da1a51cb87f636664ebac817b1d20ab 
> 
> Diff: https://git.reviewboard.kde.org/r/121831/diff/
> 
> 
> Testing
> -------
> 
> Compiles and runs. Data is still shown; no visible error. Unit tests succeed.
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150221/ce9e6ce8/attachment.htm>