Review request: QBluez

David Rosca nowrep at gmail.com
Wed Feb 18 10:50:01 GMT 2015


> If it's an expected situation, handle the situation.

I have modified the tests (only the ones who would fail) so they will
be skipped if Bluez 4 is detected.

I have also renamed the library to BluezQt. Here is an updated
documentation: http://david.rosca.cz/bluezqt-apidocs/html/

David

On Wed, Feb 18, 2015 at 2:19 AM, Thiago Macieira <thiago at kde.org> wrote:
> On Tuesday 17 February 2015 23:00:15 Albert Astals Cid wrote:
>> > It doesn't have the DBus
>> > ObjectManager, so that call should fail like that.
>>
>> Well, then the test should try to detect it and QEXPECT_FAIL, havign tests
>> fail means something is bad, and as you say it's not bad, just expected.
>
> QEXPECT_FAIL is when you know it's wrong but either can't solve it or can't do
> it now.
>
> If it's an expected situation, handle the situation.
> --
> Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
>    Software Architect - Intel Open Source Technology Center
>       PGP/GPG: 0x6EF45358; fingerprint:
>       E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
>




More information about the kde-core-devel mailing list