Review Request 122556: Bump Qt version to 5.4
Kevin Funk
kfunk at kde.org
Fri Feb 13 08:56:53 GMT 2015
> On Feb. 13, 2015, 8:41 a.m., Martin Gräßlin wrote:
> > AFAIK our CI system doesn't support Qt 5.4 yet. I think we should first ensure the CI system is prepared for building with the new dependency.
>
> Albert Astals Cid wrote:
> It does
> http://build.kde.org/job/kde-baseapps_master_qt5/238/consoleFull
> ==== qt5 - Branch 5.4.1
Are we sure we want to depend on 5.4 just yet for such a central part of the KDE workspace? I don't know the policies, but I'm curious.
Qt 5.4 is not even available on Kubuntu Vivid 15.04 yet.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122556/#review75971
-----------------------------------------------------------
On Feb. 13, 2015, 8:06 a.m., Arjun AK wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122556/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2015, 8:06 a.m.)
>
>
> Review request for KDE Base Apps.
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> `QUrl::fromUserInput(userInput, workingDirectory, UserInputResolutionOptions options)` seems to be Qt 5.4+. We either need to bump requirement to 5.4 or do what kompare [did](https://projects.kde.org/projects/kde/kdesdk/kompare/repository/revisions/master/entry/libdialogpages/diffpage.cpp#L45)
>
>
> Diffs
> -----
>
> CMakeLists.txt 6df9015
>
> Diff: https://git.reviewboard.kde.org/r/122556/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun AK
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150213/1df5c600/attachment.htm>
More information about the kde-core-devel
mailing list