Review Request 122534: [konq-plugins] fsview: Add missing include(ECMMarkAsTest)

Kevin Funk kfunk at kde.org
Wed Feb 11 23:34:30 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122534/#review75894
-----------------------------------------------------------


I'd move that line to the top CMakeLists.txt. 

And remove the duplicate ones in other CMakeLists.txt files.

- Kevin Funk


On Feb. 11, 2015, 9:43 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122534/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2015, 9:43 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> [konq-plugins] fsview: Add missing include(ECMMarkAsTest)
> 
> 
> Diffs
> -----
> 
>   konq-plugins/fsview/tests/CMakeLists.txt 4ee03006999dfb62c25a36bb643f92c3078697b6 
> 
> Diff: https://git.reviewboard.kde.org/r/122534/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150211/8a8697ae/attachment.htm>


More information about the kde-core-devel mailing list