Review Request 122475: Fix bug 343906 - Unable to handle plain directory paths as QUrl

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122475/#review75655
-----------------------------------------------------------



dolphin/src/main.cpp
<https://git.reviewboard.kde.org/r/122475/#comment52312>

    I would add an:
    else {
    qWarning() << "couldn't create a valid url for" << str;
    }
    
    Maybe it should even return, it's not nice trying something, getting the application running but not doing what you expected it to.


- Aleix Pol Gonzalez


On Feb. 8, 2015, 4:46 a.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122475/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2015, 4:46 a.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Bugs: 343906
>     http://bugs.kde.org/show_bug.cgi?id=343906
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> URLs passed as commandline arguments should be constructed using `QUrl::fromUserInput()`
> 
> 
> Diffs
> -----
> 
>   dolphin/src/main.cpp 094402f 
> 
> Diff: https://git.reviewboard.kde.org/r/122475/diff/
> 
> 
> Testing
> -------
> 
> dolphin /tmp
> dolphin ftp.debian.org
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150209/308f7b03/attachment.htm>