Review Request 122475: Fix bug 343906 - Unable to handle plain directory paths as QUrl

[Arjun AK]

> On Feb. 8, 2015, 2:01 p.m., Emmanuel Pescosta wrote:
> > dolphin/src/main.cpp, line 109
> > <https://git.reviewboard.kde.org/r/122475/diff/1/?file=347895#file347895line109>
> >
> >     The validation isn't needed anymore, because QUrl::fromUserInput always returns a valid url. (see QUrl doc)

No it doesn't.


>Returns a valid URL from a user supplied userInput string if one can be deducted. In the case that is not possible, an invalid QUrl() is returned


- Arjun


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122475/#review75583
-----------------------------------------------------------


On Feb. 8, 2015, 9:16 a.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122475/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2015, 9:16 a.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Bugs: 343906
>     http://bugs.kde.org/show_bug.cgi?id=343906
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> URLs passed as commandline arguments should be constructed using `QUrl::fromUserInput()`
> 
> 
> Diffs
> -----
> 
>   dolphin/src/main.cpp 094402f 
> 
> Diff: https://git.reviewboard.kde.org/r/122475/diff/
> 
> 
> Testing
> -------
> 
> dolphin /tmp
> dolphin ftp.debian.org
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150209/92b2e178/attachment.htm>