Review Request 122471: Enable Compilation of about Protocol
David Faure
faure at kde.org
Sun Feb 8 09:30:14 GMT 2015
> On Feb. 8, 2015, 9:19 a.m., Laurent Montel wrote:
> > about/kio_about.cpp, line 59
> > <https://git.reviewboard.kde.org/r/122471/diff/1/?file=347423#file347423line59>
> >
> > QApplication app(argc, argv); app.setApplicationName(QLatin1String("kio_about"));
> >
> > => you remove KComponentData which is in kdelibs4support
Well, QCoreApplication is enough.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122471/#review75584
-----------------------------------------------------------
On Feb. 7, 2015, 10:23 p.m., David Narváez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122471/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2015, 10:23 p.m.)
>
>
> Review request for kde-workspace and David Faure.
>
>
> Repository: kio-extras
>
>
> Description
> -------
>
> Basically porting away from QUrl and KDE_EXPORT
>
>
> Diffs
> -----
>
> CMakeLists.txt 3379ce7
> about/kio_about.h 620d6aa
> about/kio_about.cpp d7396d8
>
> Diff: https://git.reviewboard.kde.org/r/122471/diff/
>
>
> Testing
> -------
>
> Tested compilation and installation:
>
> $ find /home/david/kio-install/ -name "*about*"
> /home/david/kio-install/lib64/plugins/kio_about.so
> /home/david/kio-install/share/kservices5/about.protocol
>
>
> Thanks,
>
> David Narváez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150208/d4da66ad/attachment.htm>
More information about the kde-core-devel
mailing list