Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122341/#review75469
-----------------------------------------------------------



thumbnail/thumbnail.cpp
<https://git.reviewboard.kde.org/r/122341/#comment52188>

    there can be one issue here, if the destination already exists (but couldn't be loaded for some reason, e.g. corrupt file).
    
    KDE::rename would overwrite an existing dest, while QFile::rename doesn't do that.
    
    The proper way to implement "save to temp file and then move over existing destination" is to use QSaveFile. It's a corner case so I'm ok with it being fixed in a later commit. Maybe in this one a QFile::remove on the dest is enough, with a comment "// not atomic! should use QSaveFile"....


- David Faure


On Feb. 5, 2015, 8:59 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122341/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2015, 8:59 a.m.)
> 
> 
> Review request for kde-workspace, Bhushan Shah and David Faure.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> Only major difference would be the lack of fallback to KFMI. Maybe we could implement thumbnail features in KFileMetadata?
> 
> 
> Diffs
> -----
> 
>   thumbnail/thumbnail.cpp 39e8de5 
> 
> Diff: https://git.reviewboard.kde.org/r/122341/diff/
> 
> 
> Testing
> -------
> 
> Only tested compilation.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150205/8de5ab12/attachment.htm>