Review Request 122320: use xcb-screen count instead of qguiapplication.screens

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122320/#review75256
-----------------------------------------------------------



components/CMakeLists.txt
<https://git.reviewboard.kde.org/r/122320/#comment52056>

    that seems unrelated change.



startkde/kcminit/CMakeLists.txt
<https://git.reviewboard.kde.org/r/122320/#comment52057>

    you find optional, but link required. OSX devs won't be happy with that change ;-)
    
    you need to do something like:
    if (XCB_XCB_FOUND)
        target_link_libraries(kdeinit_kcminit XCB::XCB)
    endif()



startkde/kcminit/CMakeLists.txt
<https://git.reviewboard.kde.org/r/122320/#comment52058>

    here the same



startkde/kcminit/main.cpp
<https://git.reviewboard.kde.org/r/122320/#comment52059>

    the ifdef is wrong: HAVE_X11 is defined as 1 if Xlib is found. It doesn't say anything about whether XCB is found. Please introduce a dedicated ifdef for it.


- Martin Gräßlin


On Feb. 2, 2015, 10:15 p.m., Nick Shaforostoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122320/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2015, 10:15 p.m.)
> 
> 
> Review request for kde-workspace, Martin Gräßlin and Thomas Lübking.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> this patch makes kcminit behave like in kde4: it uses proper xcb screen count which may be different from QGuiApplication::screens().count().
> 
> for example when i connext external monitor via vga to my laptop, xcb screen count is still '1', while QGuiApplication::screens().count() returns '2'.
> 
> switching from QGuiApplication to QCoreApplication still wasn't possible because modules like 'mouse' need gui initialized and would crash if kcminit uses QCoreApplication.
> 
> 
> Diffs
> -----
> 
>   components/CMakeLists.txt 42c820f 
>   startkde/kcminit/CMakeLists.txt b17951f 
>   startkde/kcminit/main.cpp 1008966 
> 
> Diff: https://git.reviewboard.kde.org/r/122320/diff/
> 
> 
> Testing
> -------
> 
> i have built kcminit on ubuntu vivid alpha 32-bit, replaced binaries and libraries in the system and successfuly could run kcminit_startup and reboot also went fine.
> 
> 
> Thanks,
> 
> Nick Shaforostoff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150203/ce10551c/attachment.htm>