Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122341/#review75090
-----------------------------------------------------------



thumbnail/thumbnail.cpp
<https://git.reviewboard.kde.org/r/122341/#comment51967>

    Why this change? It's very wrong.
    
    The first arg is a mimetype, therefore you need KMimeTypeTrader.
    
    It compiles with KServiceTypeTrader by stuffing the mimetype into "const QString& serviceType" and by stuffing the servicetype into "const QString &constraint"...



thumbnail/thumbnail.cpp
<https://git.reviewboard.kde.org/r/122341/#comment51965>

    This (which predates this patch) is wrong, it should be QUrl::fromLocalFile(filePath).
    
    And then I would rename this variable to fileUrl or something, to make it clearer that it's a URL.



thumbnail/thumbnail.cpp
<https://git.reviewboard.kde.org/r/122341/#comment51966>

    This will be in the current dir, it should probably be QDir::tempPath() + "/kde-...." instead.


- David Faure


On Jan. 31, 2015, 11:07 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122341/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2015, 11:07 p.m.)
> 
> 
> Review request for kde-workspace, Bhushan Shah and David Faure.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> Only major difference would be the lack of fallback to KFMI. Maybe we could implement thumbnail features in KFileMetadata?
> 
> 
> Diffs
> -----
> 
>   thumbnail/thumbnail.cpp 39e8de5 
> 
> Diff: https://git.reviewboard.kde.org/r/122341/diff/
> 
> 
> Testing
> -------
> 
> Only tested compilation.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150201/3c354e8b/attachment.htm>