Review Request 122212: [baseapps] Make tests optional

Andreas Sturmlechner andreas.sturmlechner at gmail.com
Sun Feb 1 09:03:23 GMT 2015



> On Jan. 23, 2015, 10:07 a.m., Emmanuel Pescosta wrote:
> > Ship It!

I'm glad you like it! Without write access, I need to ask for someone else to merge.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122212/#review74587
-----------------------------------------------------------


On Jan. 22, 2015, 9:24 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122212/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2015, 9:24 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> CMakeLists.txt - remove Test from find_package
> dolphin/src/CMakeLists.txt - build tests only if BUILD_TESTING
> lib/konq/CMakeLists.txt - add find_package(Qt5Test...)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 6df90151166ae5b042518b3b91daaf1dde83118b 
>   dolphin/src/CMakeLists.txt d2ea4931431bf6b73ec9fa46ae84a7a65d142d6b 
>   lib/konq/CMakeLists.txt cd61c5b7c7e1bb005449626b44665f4fa31b275d 
> 
> Diff: https://git.reviewboard.kde.org/r/122212/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150201/a611a351/attachment.htm>


More information about the kde-core-devel mailing list