Review Request 126413: FindPyKDE4: Make PYKDE4_INSTALL_PYTHON_FILES use PYTHON_INSTALL.

[Luca Beltrame]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126413/#review89701
-----------------------------------------------------------

Ship it!


Inviala!

- Luca Beltrame


On Dic. 18, 2015, 1:12 p.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126413/
> -----------------------------------------------------------
> 
> (Updated Dic. 18, 2015, 1:12 p.m.)
> 
> 
> Review request for Build System, kdelibs, Alex Merry, and Luca Beltrame.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Review Request 126345 ("PythonMacros: specify destination directory in byte-compiled files") broke Kajongg's build because it uses the `PYKDE4_INSTALL_PYTHON_FILES()` macro, whose use of `PythonCompile.py` had not been updated.
> 
> Instead of just passing `--destination-dir` in `FindPyKDE4.cmake`, rewrite the `PYKDE4_INSTALL_PYTHON_FILES()` macro to use PythonMacros's `PYTHON_INSTALL()`. Not only does this fix Kajongg's build, but it also removes a lot of code duplication and makes `PYKDE4_INSTALL_PYTHON_FILES()` work with Python 3.2+'s different .pyc location.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindPyKDE4.cmake 3b87963 
> 
> Diff: https://git.reviewboard.kde.org/r/126413/diff/
> 
> 
> Testing
> -------
> 
> Kajongg builds again. According to LXR `FindPyKDE4.cmake` and `PythonMacros.py` are the only two places invoking `PythonCompile.py`, so all callers should work now.
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20151218/9d9c9392/attachment.htm>