Review Request 102149: Improve Calculate/Stop buttons when folder Size is being calculated

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/102149/
-----------------------------------------------------------

(Updated Dez. 15, 2015, 9:54 nachm.)


Status
------

This change has been discarded.


Review request for kdelibs.


Repository: kdelibs


Description
-------

This patch improves the Calculate and Stop buttons in folder properties.
Instead of having two buttons that are enabled/disabled accordingly, we only have one that toggles (technically there are still two buttons but it looks as if there was one)

I removed that "Calculating..." label when there is already a size shown, instead the stop button says "Stop Calculating" and somehow serves as "indicator".
Also, I added a line-break after the "Calculating..." so the label doesn't change its size making the other elements moving around.

I don't know if the additional icons (view-refresh and process-cancel) add too much clutter to the visual interface since this features is not sooo important/frequently used(?) that the buttons need an icon.


Diffs
-----

  kio/kfile/kpropertiesdialog.cpp ba56f18 

Diff: https://git.reviewboard.kde.org/r/102149/diff/


Testing
-------

Compiles and the buttons toggle (and react) fine.


Screenshots
-----------

Screenshot of the dialog while it is calculating
  https://git.reviewboard.kde.org/r/102149/s/213/


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20151215/5b17fbcc/attachment.htm>