[KDE Usability] Review Request 110266: Cleanp Places Panel context menu

Kai Uwe Broulik kde at privat.broulik.de
Tue Dec 15 21:52:18 GMT 2015

This is an automatically generated e-mail. To reply, visit:

(Updated Dez. 15, 2015, 9:52 nachm.)


This change has been discarded.

Review request for kdelibs, KDE Usability, Aaron J. Seigo, and Frank Reininghaus.

Repository: kdelibs


This is a follow-up review request for Review 109015 which does the same for Dolphin.

This patch cleans up the places panel context menu by:
 - Removing the term "Entry" and the entry name in every single item. To still have easy context, I added a menu title instead.
 - General actions such as "Show all" and "Add Entry" are removed from item context menus (they're not related to the item)

See screenshot for direct comparison of old and new.

You can still add an entry, even if the list is full, by scrolling to the bottom of the list where there is always an empty spot to click on. To me it sounds logical to add an entry at the end anyway. (Dolphin doesn't directly have this problem since you can always click the group titles (Devices, Places, Search For, …) which are not considered an item and thus spawn the general context menu)

For Frameworks 5 it would of course be great to merge Dolphin's places panel duplication back into kdelibs to provide a unified user experience and reduce maintenance cost. (Or write a new one based on QML, :P)


  kfile/kfileplacesmodel.cpp a73274c 
  kfile/kfileplacesview.cpp 117a9ed 

Diff: https://git.reviewboard.kde.org/r/110266/diff/


Tested in the Open File dialog of Kolourpaint. Looks nice, works.

File Attachments

Comparison (left old, right new)


Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20151215/079e2357/attachment.htm>
-------------- next part --------------
kde-usability mailing list
kde-usability at kde.org

More information about the kde-core-devel mailing list