Review Request 126253: kxmlgui.xsd add Separator append attribute
Allen Winter
winter at kde.org
Sun Dec 6 16:07:08 GMT 2015
> On Dec. 6, 2015, 3:17 p.m., Martin Walch wrote:
> > Should the specification in kpartgui.dtd also be updated?
Krazy doesn't look at kpartgui.dtd . I don't know what kpartgui.dtd is used for.
I suppose adding the line "append CDATA #IMPLIED" into the Separator ATTLIST (line 125) would work.
<!ELEMENT Separator EMPTY>
<!ATTLIST Separator
lineSeparator (true|false) "true"
weakSeparator (true|false) "true"
append CDATA #IMPLIED
group CDATA #IMPLIED
>
Any experts out there with an opinion?
- Allen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126253/#review89184
-----------------------------------------------------------
On Dec. 6, 2015, 2:34 p.m., Allen Winter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126253/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2015, 2:34 p.m.)
>
>
> Review request for kdelibs and Martin Walch.
>
>
> Bugs: 356134
> https://bugs.kde.org/show_bug.cgi?id=356134
>
>
> Repository: kxmlgui
>
>
> Description
> -------
>
> Add an append attribute to the Separator Element of the kxmlgui.xsd
>
>
> Diffs
> -----
>
> src/kxmlgui.xsd da1d155
>
> Diff: https://git.reviewboard.kde.org/r/126253/diff/
>
>
> Testing
> -------
>
> added to Krazy now. no longer see the xmllint warnings in kolf
>
>
> Thanks,
>
> Allen Winter
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20151206/f46b2173/attachment.htm>
More information about the kde-core-devel
mailing list