Plasma Applet for Audio Volume for kdereview

[Sebastian Kügler]

On Thursday, August 06, 2015 12:25:32 Burkhard Lück wrote:
> Am Donnerstag, 6. August 2015, 00:40:41 schrieb Albert Astals Cid:
> > Missing or not so good i18n
> >
> > ./src/kcm/package/contents/ui/VolumeSlider.qml:84:        text:
> > Math.floor(slider.value / slider.maximumValue * 100.0) + "%"
> > ./src/kcm/package/contents/ui/VolumeSlider.qml:90:        text: "100%"
> > ./src/kcm/package/contents/ui/StreamListItem.qml:55:                   
> > text: PulseObject.client.name + ": " + PulseObject.name
> > ./src/kcm/package/contents/ui/main.qml:33:    ConfigModule.quickHelp:
> > "((UNKNOWN))"
> > ./applet/contents/ui/ListItemBase.qml:208:                   
> >     text: Math.floor(slider.value / slider.maximumValue * 100.0) + "%"
> > ./applet/contents/ui/ListItemBase.qml:230:        text: "100%"
> > ./applet/contents/ui/StreamListItemBase.qml:28:    label:
> > PulseObject.client.name + ": " + PulseObject.name
> 
> Please keep in mind that some langs show the "%" sign before the value, so
> it  should be i18n("%1%", value) for percent values

All i18n issues pointed out have been fixed.

Thanks for the review,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9