Review Request 122556: Bump Qt version to 5.4
Emmanuel Pescosta
emmanuelpescosta099 at gmail.com
Sun Aug 9 17:38:32 BST 2015
> On Aug. 9, 2015, 3:33 p.m., Nikita Skovoroda wrote:
> > What's the status of this?
> > Dolphin (and maybe some other apps) already depends on 5.4.
>
> Nikita Skovoroda wrote:
> Plasma and Kwin require Qt 5.4 since Plasma 5.3.0 release, btw.
>
> Luigi Toscano wrote:
> Plasma (and Kwin, which is part of Plasma) are not relevant for this review, as they are a different product than KDE Applications.
>
> On the other side, the fact that some applications (Dolphin) require Qt 5.4 is relevant (and the fact that this review is 5 months old and Qt 5.4 is now widely available too). Also, as Frank pointed out, kde-baseapps is still releaseing from a kdelibs4-based master branch, so this dependency will apply not before KDE Applications 15.12.
> What's the status of this?
This review request can be closed, because the necessary changes are already in master and in Applications/15.08. (see http://goo.gl/F2tZKl)
- Emmanuel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122556/#review83601
-----------------------------------------------------------
On Feb. 13, 2015, 9:06 a.m., Arjun AK wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122556/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2015, 9:06 a.m.)
>
>
> Review request for KDE Base Apps.
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> `QUrl::fromUserInput(userInput, workingDirectory, UserInputResolutionOptions options)` seems to be Qt 5.4+. We either need to bump requirement to 5.4 or do what kompare [did](https://projects.kde.org/projects/kde/kdesdk/kompare/repository/revisions/master/entry/libdialogpages/diffpage.cpp#L45)
>
>
> Diffs
> -----
>
> CMakeLists.txt 6df9015
>
> Diff: https://git.reviewboard.kde.org/r/122556/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun AK
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150809/733ce44d/attachment.htm>
More information about the kde-core-devel
mailing list