Review Request 124657: Show URL again in bookmarks view and URL texbox

Luigi Toscano luigi.toscano at tiscali.it
Sun Aug 9 00:47:22 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124657/
-----------------------------------------------------------

(Updated Aug. 8, 2015, 11:47 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Base Apps and David Faure.


Changes
-------

Submitted with commit 64e8b30cf24623c52595efca3f57bc776c5ca188 by Luigi Toscano to branch frameworks.


Repository: kde-baseapps


Description
-------

Fix two KUrl porting TODO items. Thanks to the porting notes!
The URL of the bookmark was not shown because the value was not
passed to the treeview/table model and to the textbox.


Diffs
-----

  keditbookmarks/bookmarkinfowidget.cpp 98ce303 
  keditbookmarks/kbookmarkmodel/model.cpp e949469 

Diff: https://git.reviewboard.kde.org/r/124657/diff/


Testing
-------

Compiled, executed the bookmark editor. Added and changed few bookmarks, the URL is correctly updated.


Thanks,

Luigi Toscano

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150808/dcd2de6b/attachment.htm>


More information about the kde-core-devel mailing list