Review Request 124657: Show URL again in bookmarks view and URL texbox

Luigi Toscano luigi.toscano at tiscali.it
Sat Aug 8 00:51:25 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124657/
-----------------------------------------------------------

(Updated Aug. 8, 2015, 1:51 a.m.)


Review request for KDE Base Apps.


Changes
-------

(Maybe) better way to build the URL


Repository: kde-baseapps


Description
-------

Fix two KUrl porting TODO items. Thanks to the porting notes!
The URL of the bookmark was not shown because the value was not
passed to the treeview/table model and to the textbox.


Diffs (updated)
-----

  keditbookmarks/bookmarkinfowidget.cpp 98ce303 
  keditbookmarks/kbookmarkmodel/model.cpp e949469 

Diff: https://git.reviewboard.kde.org/r/124657/diff/


Testing
-------

Compiled, executed the bookmark editor. Added and changed few bookmarks, the URL is correctly updated.


Thanks,

Luigi Toscano

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150807/e583347a/attachment.htm>


More information about the kde-core-devel mailing list