Review Request 122987: Allow user to specify path to myspell dictionary files

[Rex Dieter]

> On April 7, 2015, 1:44 a.m., Aleix Pol Gonzalez wrote:
> > This doesn't let the user change the path but the distributor, that's quite a different thing. Maybe it should be a runtime check?

Ideally yes, but the approach taken here so far is at least an incremental improvement over the status quo.  So, I wouldn't let "perfect" be the enemy of "good" here


- Rex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review78586
-----------------------------------------------------------


On April 27, 2015, 1:30 p.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122987/
> -----------------------------------------------------------
> 
> (Updated April 27, 2015, 1:30 p.m.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Repository: sonnet
> 
> 
> Description
> -------
> 
> Not on all systems myspell dictionaries are located in /usr/share/myspell/dicts/,  which is hardcoded in the hunspell plugin sources. For instance, on Gentoo it is /usr/share/myspell/. So let the user define this path.
> 
> 
> Diffs
> -----
> 
>   src/plugins/hunspell/CMakeLists.txt e35fe8c 
>   src/plugins/hunspell/config-hunspellplugin.h.cmake PRE-CREATION 
>   src/plugins/hunspell/hunspellclient.cpp 46963ef 
>   src/plugins/hunspell/hunspelldict.cpp fda4a4c 
> 
> Diff: https://git.reviewboard.kde.org/r/122987/diff/
> 
> 
> Testing
> -------
> 
> hunspell plugin began to work on Gentoo
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150805/24f56649/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel